STYLE: Reorganize wrapping files to ease PA3DSCI migration to ITK core

KitwareMedical · Jul 6, 2023 · fcc515b · fcc515b
1 parent 6f6fc8f
commit fcc515b
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 35 deletions.
diff --git a/wrapping/CMakeLists.txt b/wrapping/CMakeLists.txt
@@ -8,17 +8,19 @@ endif()
 
 itk_wrap_module(Ultrasound)
 set(WRAPPER_SUBMODULE_ORDER
+  itkSpecialCoordinatesImage  # must come before CASCI and PA3DSCI
   itkCurvilinearArraySpecialCoordinatesImage
-  itkImageUltrasound # Extra itk::Image wrappings for SupportWindow filters
   itkCurvilinearArraySpecialCoordinatesImageFilters
-  itkPhasedArray3DSpecialCoordinatesImage # CASCI needs to come before
+  itkPhasedArray3DSpecialCoordinatesImage
+  itkPhasedArray3DSpecialCoordinatesImageFilters
   itkAttenuationImageFilter
   itkBlockMatchingMetricImageFilter
   itkBlockMatchingNormalizedCrossCorrelationMetricImageFilter
   itkBlockMatchingNormalizedCrossCorrelationFFTMetricImageFilter
   itkBlockMatchingNormalizedCrossCorrelationNeighborhoodIteratorMetricImageFilter
+  itkImageUltrasound # must come before Spectra1DSupportWindow
   itkSpectra1DSupportWindowImageFilter
-  itkSpectra1DSupportWindowToMaskImageFilter
+  itkSpectra1DSupportWindowToMaskImageFilter  # must come after CASCI and PA3DSCI
   itkFrequencyDomain1DFilterFunction
   itkFrequencyDomain1DImageFilter
   itkRegionFromReferenceImageFilter

diff --git a/wrapping/itkCurvilinearArraySpecialCoordinatesImage.wrap b/wrapping/itkCurvilinearArraySpecialCoordinatesImage.wrap
@@ -1,19 +1,5 @@
-itk_wrap_include("list")
 itk_wrap_include("complex")
 
-# Wrap underlying class hierarchy
-itk_wrap_class("itk::SpecialCoordinatesImage" POINTER)
-  foreach(d ${ITK_WRAP_IMAGE_DIMS})
-    foreach(t ${WRAP_ITK_SCALAR})
-      itk_wrap_template("${ITKM_${t}}${d}" "${ITKT_${t}}, ${d}")
-    endforeach()
-    foreach(t3 ${WRAP_ITK_COMPLEX_REAL})
-      itk_wrap_template("${ITKM_${t3}}${d}" "${ITKT_${t3}}, ${d}")
-    endforeach()
-  endforeach()
-itk_end_wrap_class()
-
-
 # Explicitly override template method wrappings so that implicit
 # scalar type is always `double` for greatest precision.
 # Adds wrapping overrides to `itkCurvilinearArraySpecialCoordinatesImage_ext.i` configured with

diff --git a/wrapping/itkCurvilinearArraySpecialCoordinatesImageFilters.wrap b/wrapping/itkCurvilinearArraySpecialCoordinatesImageFilters.wrap
@@ -93,16 +93,6 @@ itk_wrap_class("itk::RescaleIntensityImageFilter" POINTER_WITH_2_SUPERCLASSES)
   endforeach()
 itk_end_wrap_class()
 
-itk_wrap_include("itkSpectra1DSupportWindowToMaskImageFilter.h")
-itk_wrap_class("itk::Spectra1DSupportWindowToMaskImageFilter" POINTER_WITH_2_SUPERCLASSES)
-  foreach(d ${ITK_WRAP_IMAGE_DIMS})
-    foreach(t ${WRAP_ITK_INT})
-      itk_wrap_template("IlistitkIndex${d}${d}CASCI${ITKM_${t}}${d}"
-        "itk::Image< std::list< itk::Index< ${d} > >, ${d} >, itk::CurvilinearArraySpecialCoordinatesImage< ${ITKT_${t}}, ${d} >")
-    endforeach()
-  endforeach()
-itk_end_wrap_class()
-
 # The rest is needed for ResampleImageFilter and interpolator functions
 set(resample_filter_dimensions 2 3)
 set(resample_filter_pixel_types "F")

diff --git a/wrapping/itkImageUltrasound.wrap b/wrapping/itkImageUltrasound.wrap
@@ -4,6 +4,8 @@
 
 itk_wrap_include("list")
 itk_wrap_include("itkIndex.h")
+itk_wrap_include("itkSpectra1DSupportWindowToMaskImageFilter.h")
+
 set(TEMPLATE_LIST_INDEX "")
 foreach(d ${ITK_WRAP_IMAGE_DIMS})
   set(TEMPLATE_LIST_INDEX "${TEMPLATE_LIST_INDEX}

diff --git a/wrapping/itkPhasedArray3DSpecialCoordinatesImage.wrap b/wrapping/itkPhasedArray3DSpecialCoordinatesImage.wrap
@@ -1,4 +1,3 @@
-itk_wrap_include("list")
 itk_wrap_include("complex")
 
 # Explicitly override template method wrappings so that implicit

diff --git a/wrapping/itkPhasedArray3DSpecialCoordinatesImageFilters.wrap b/wrapping/itkPhasedArray3DSpecialCoordinatesImageFilters.wrap
@@ -81,13 +81,6 @@ itk_wrap_class("itk::RescaleIntensityImageFilter" POINTER_WITH_2_SUPERCLASSES)
   endforeach()
 itk_end_wrap_class()
 
-itk_wrap_include("itkSpectra1DSupportWindowToMaskImageFilter.h")
-itk_wrap_class("itk::Spectra1DSupportWindowToMaskImageFilter" POINTER_WITH_2_SUPERCLASSES)
-    foreach(t ${WRAP_ITK_INT})
-      itk_wrap_template("IlistitkIndex33PA3DSCI${ITKM_${t}}"
-        "itk::Image< std::list< itk::Index< 3 > >, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< ${ITKT_${t}} >")
-    endforeach()
-itk_end_wrap_class()
 
 # The rest is needed for ResampleImageFilter and interpolator functions
 set(resample_filter_pixel_types "F")

diff --git a/wrapping/itkSpecialCoordinatesImage.wrap b/wrapping/itkSpecialCoordinatesImage.wrap
@@ -0,0 +1,13 @@
+itk_wrap_include("complex")
+
+# Wrap underlying class hierarchy
+itk_wrap_class("itk::SpecialCoordinatesImage" POINTER)
+  foreach(d ${ITK_WRAP_IMAGE_DIMS})
+    foreach(t ${WRAP_ITK_SCALAR})
+      itk_wrap_template("${ITKM_${t}}${d}" "${ITKT_${t}}, ${d}")
+    endforeach()
+    foreach(t3 ${WRAP_ITK_COMPLEX_REAL})
+      itk_wrap_template("${ITKM_${t3}}${d}" "${ITKT_${t3}}, ${d}")
+    endforeach()
+  endforeach()
+itk_end_wrap_class()
diff --git a/wrapping/itkSpectra1DSupportWindowToMaskImageFilter.wrap b/wrapping/itkSpectra1DSupportWindowToMaskImageFilter.wrap
@@ -1,11 +1,23 @@
 itk_wrap_include("list")
 itk_wrap_include("itkIndex.h")
 itk_wrap_include("itkImage.h")
+itk_wrap_include("itkPhasedArray3DSpecialCoordinatesImage.h")
+itk_wrap_include("itkCurvilinearArraySpecialCoordinatesImage.h")
 
 itk_wrap_class("itk::Spectra1DSupportWindowToMaskImageFilter" POINTER_WITH_2_SUPERCLASSES)
   foreach(d ${ITK_WRAP_IMAGE_DIMS})
     foreach(t ${WRAP_ITK_INT})
       itk_wrap_template("IlistitkIndex${d}${d}${ITKM_I${t}${d}}" "itk::Image< std::list< itk::Index< ${d} > >, ${d} >, ${ITKT_I${t}${d}}")
     endforeach(t)
   endforeach(d)
+  foreach(t ${WRAP_ITK_INT})
+    itk_wrap_template("IlistitkIndex33PA3DSCI${ITKM_${t}}"
+      "itk::Image< std::list< itk::Index< 3 > >, 3 >, itk::PhasedArray3DSpecialCoordinatesImage< ${ITKT_${t}} >")
+  endforeach()
+  foreach(d ${ITK_WRAP_IMAGE_DIMS})
+    foreach(t ${WRAP_ITK_INT})
+      itk_wrap_template("IlistitkIndex${d}${d}CASCI${ITKM_${t}}${d}"
+        "itk::Image< std::list< itk::Index< ${d} > >, ${d} >, itk::CurvilinearArraySpecialCoordinatesImage< ${ITKT_${t}}, ${d} >")
+    endforeach()
+  endforeach()
 itk_end_wrap_class()