Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Improve pathing based on OS #359

Merged
merged 10 commits into from
Aug 26, 2024
Merged

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Aug 24, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #358

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.20 milestone Aug 24, 2024
@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Improve pathing based on OS Aug 24, 2024
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview 💎enhancement An improvement on something labels Aug 24, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Aug 24, 2024
@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review August 26, 2024 22:02
@CalvinWilkinson
Copy link
Member Author

Note

Added the following 💎enhancement An improvement on something 's

  1. Improved the pathing to use the \ directory separator on Windows consistently. This helps improve expectations with paths based on the operating system for library consumers.

@CalvinWilkinson
Copy link
Member Author

Note

Improvements made to the 📑documentation-code Code documentation changes in source code. XML code docs/comments
Various grammar and spelling issues fixed across the code base.

@CalvinWilkinson CalvinWilkinson merged commit 0448b63 into preview Aug 26, 2024
8 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/358-improve-pathing branch August 26, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎enhancement An improvement on something high-priority High Priority preview Done while in preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Improve pathing based on OS
2 participants