Update dfdutils-included vulkan_core.h. #783
Conversation
|
@aqnuep here is the updated Vulkan header. Some of the new tools tests are failing. I can't do any more tonight so I have pushed the branch and made a PR. I wanted to make this a work-in-progress PR but can't find the relevant control. The test failures are most likely due to output strings. The ASTC HDR extension has become part of Vulkan core so there are now enums without the trailing _EXT in the name. This PR changes all the code to use the undecorated enums. I did not re-build the CTS tests as I have no time left. Hope this helps. |
|
The test failures I've looked at so far have the form I don't see any output from the command being run (presumably ktx info in this case) so I'm not sure how to debug further. Please advise @aqnuep. |
Improvements to clitests to allow @MarkCallow to more easily investigate his issues in PR #783. @MarkCallow, please merge CTS PR KhronosGroup/KTX-Software-CTS#6 first. It would also be great to get write access to the CTS repo in general.
MarkCallow
changed the title
MarkCallow
force-pushed
the
update_vkheader
branch
from
3d1b9a8
to
9506e0c
Compare
|
I've fixed all the tests. The open question is should the --format option to |
|
The core changes look good, but I see a lot of seemingly unrelated changes. Is that all just cleanup, or should I take a deeper look into those too? |
Are you referring to the changes to the make file, test programs and doxy file in The |
|
Yes, I was referring to those changes. If all of those changes are intentional then it's all good. |
ASTC HDR enums are now core so all code that used the _EXT names has been updated.
Reinstate conditionals for setting VULKAN_SDK include.
Add --suppress-deprecation to reuse run.
Update cts ref to latest with _EXT tests.
makevk2dfd.pl has been made "strict" and "warning" free. Since the related fixes did not fix the input problem, the same was not done to makedfd2vk.pl.
MarkCallow
force-pushed
the
update_vkheader
branch
from
5de5b31
to
e2f8a4d
Compare
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code and
tests to use the non _EXT names. Make `ktx create --format` accept both
variants of the format name.
Fix mkvkformatfiles to add format aliases to `stringToVkFormat`.
Fix dfdutils scripts to not create duplicate cases for _{EXT,KHR} and
non-_{EXT,KHR} names.
Fix long standing bug in the dfdutils scripts where they were reading as input both
files given on the command line.
Add instructions and a script for regenerating vulkan_core.h from vk.xml.
Do not look for the VulkanSDK for mkvk target as it does not use the SDK's
vulkan_core.h and hasn't for some time.
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code and
tests to use the non _EXT names. Make `ktx create --format` accept both
variants of the format name.
Fix mkvkformatfiles to add format aliases to `stringToVkFormat`.
Fix dfdutils scripts to not create duplicate cases for _{EXT,KHR} and
non-_{EXT,KHR} names.
Fix long standing bug in the dfdutils scripts where they were reading as input both
files given on the command line.
Add instructions and a script for regenerating vulkan_core.h from vk.xml.
Do not look for the VulkanSDK for mkvk target as it does not use the SDK's
vulkan_core.h and hasn't for some time.
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code and
tests to use the non _EXT names. Make `ktx create --format` accept both
variants of the format name.
Fix mkvkformatfiles to add format aliases to `stringToVkFormat`.
Fix dfdutils scripts to not create duplicate cases for _{EXT,KHR} and
non-_{EXT,KHR} names.
Fix long standing bug in the dfdutils scripts where they were reading as input both
files given on the command line.
Add instructions and a script for regenerating vulkan_core.h from vk.xml.
Do not look for the VulkanSDK for mkvk target as it does not use the SDK's
vulkan_core.h and hasn't for some time.
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code and
tests to use the non _EXT names. Make `ktx create --format` accept both
variants of the format name.
Fix mkvkformatfiles to add format aliases to `stringToVkFormat`.
Fix dfdutils scripts to not create duplicate cases for _{EXT,KHR} and
non-_{EXT,KHR} names.
Fix long standing bug in the dfdutils scripts where they were reading as input both
files given on the command line.
Add instructions and a script for regenerating vulkan_core.h from vk.xml.
Do not look for the VulkanSDK for mkvk target as it does not use the SDK's
vulkan_core.h and hasn't for some time.
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code and
tests to use the non _EXT names. Make `ktx create --format` accept both
variants of the format name.
Fix mkvkformatfiles to add format aliases to `stringToVkFormat`.
Fix dfdutils scripts to not create duplicate cases for _{EXT,KHR} and
non-_{EXT,KHR} names.
Fix long standing bug in the dfdutils scripts where they were reading as input both
files given on the command line.
Add instructions and a script for regenerating vulkan_core.h from vk.xml.
Do not look for the VulkanSDK for mkvk target as it does not use the SDK's
vulkan_core.h and hasn't for some time.
ASTC HDR and A4B4G4R4_UNORM formats are now core. Update all code to use the non _EXT names.
Add instructions and a script for regnerating vulkan_core.h.