Undo change to revolute joint rand_configuration! distribution.
#517
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably too many things tacitly assume this distribution at some point. Should revisit as part of #459, but we shouldn't introduce backwards incompatible changes right now.
tkoolen
changed the title
rand_configuration! distribution.
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 99.23% 99.23% +<.01%
==========================================
Files 38 38
Lines 1702 1703 +1
==========================================
+ Hits 1689 1690 +1
Misses 13 13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably too many things tacitly assume this distribution at this point.
Should revisit as part of #459, but we shouldn't introduce backwards
incompatible changes right now.
(Note: the change to
rand(-pi, pi)caused a RigidBodySim test to fail).