Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call rand during sysimage precompilation #56227

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Do not call rand during sysimage precompilation #56227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5393c
Do not call `rand` during sysimage precompilation
Oct 18, 2024
fcd1f96
Update contrib/generate_precompile.jl
giordano Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contrib/generate_precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,10 @@ for match = Base._methods(+, (Int, Int), -1, Base.get_world_counter())
# interactive startup uses this
write(IOBuffer(), "")

# not critical, but helps hide unrelated compilation from @time when using --trace-compile
foo() = rand(2,2) * rand(2,2)
@time foo()
@time foo()
# Not critical, but helps hide unrelated compilation from @time when using --trace-compile.
f55729() = Base.Experimental.@force_compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works, but probably not for the reasons you intended. You're trying to using the local variable f55729 as a global, causing nothing to happen:
UndefVarError: `f55729` not defined in `Main

@time @eval f55729()
@time @eval f55729()

break # only actually need to do this once
end
Expand Down