Do not call rand during sysimage precompilation
#56227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
compiler:precompilation
Co-authored-by: Ian Butterworth <[email protected]>
IanButterworth
approved these changes
Oct 18, 2024
IanButterworth
added
the
merge me
giordano
added a commit
that referenced
this pull request
Oct 19, 2024
This change by itself doesn't do anything significant on `master`, but when backported to the v1.11 branch it'll address #56177. However it'd be great if someone could tell _why_ this fixes that issue, because it looks very unrelated. --------- Co-authored-by: Ian Butterworth <[email protected]> (cherry picked from commit f36f342)
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
This change by itself doesn't do anything significant on `master`, but when backported to the v1.11 branch it'll address #56177. However it'd be great if someone could tell _why_ this fixes that issue, because it looks very unrelated. --------- Co-authored-by: Ian Butterworth <[email protected]>
vtjnash
reviewed
Oct 22, 2024
| @time foo() | ||
| @time foo() | ||
| # Not critical, but helps hide unrelated compilation from @time when using --trace-compile. | ||
| f55729() = Base.Experimental.@force_compile |
There was a problem hiding this comment.
This PR works, but probably not for the reasons you intended. You're trying to using the local variable f55729 as a global, causing nothing to happen:
UndefVarError: `f55729` not defined in `Main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change by itself doesn't do anything significant on
master, but when backported to the v1.11 branch it'll address #56177. However it'd be great if someone could tell why this fixes that issue, because it looks very unrelated.