ProcessWatchdog: no longer fail on exit code 259 on Windows #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous implementation of ProcessWatchdog was susceptible to a well-known issue of GetProcessExitCode: if the process' real exit code is STILL_ALIVE, then there's no way to determine that it has exited, because this number is equal to a special value that function returns for a living process. This new implementation fixes that, and also introduces a new, better API to pass more arguments (mostly for the purpose of testing).
ForNeVeR
force-pushed
the
im/process-watchdog-improvements
branch
from
cc5085e
to
a96a008
Compare
LogLog.StoredRecords is a copy of the source list; clearing it has no effect on the actual stored contents.
ForNeVeR
force-pushed
the
im/process-watchdog-improvements
branch
from
63b26a3
to
5d61b6e
Compare
…timeout timeout was behaving weirdly in cmd with IO redirection.
ForNeVeR
force-pushed
the
im/process-watchdog-improvements
branch
2 times, most recently
from
a8b5b3c
to
7e3d773
Compare
This code is out of range of valid exit codes on Unix anyway.
ForNeVeR
force-pushed
the
im/process-watchdog-improvements
branch
from
7e3d773
to
ef45bfa
Compare
Iliya-usov
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous implementation of ProcessWatchdog was susceptible to a well-known issue of
GetProcessExitCode: if the process' real exit code isSTILL_ALIVE, then there's no way to determine that it has exited, because this number is equal to a special value that function returns for a living process.This new implementation fixes that, and also introduces a new, better API to pass more arguments (mostly for the purpose of testing).