Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessWatchdog: no longer fail on exit code 259 on Windows #450

Merged
merged 5 commits into from
Dec 3, 2023

Commits on Nov 30, 2023

  1. ProcessWatchdog: no longer fail on exit code 259 on Windows

    Our previous implementation of ProcessWatchdog was susceptible to a
    well-known issue of GetProcessExitCode: if the process' real exit code
    is STILL_ALIVE, then there's no way to determine that it has exited,
    because this number is equal to a special value that function returns
    for a living process.
    
    This new implementation fixes that, and also introduces a new, better
    API to pass more arguments (mostly for the purpose of testing).
    ForNeVeR committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a96a008 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Tests: properly clear the exceptions stored in LogLog

    LogLog.StoredRecords is a copy of the source list; clearing it has no
    effect on the actual stored contents.
    ForNeVeR committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    2e42a45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d61b6e View commit details
    Browse the repository at this point in the history
  3. ProcessWatchdogTest: improve diagnostics, migrate to ping instead of …

    …timeout
    
    timeout was behaving weirdly in cmd with IO redirection.
    ForNeVeR committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    d2107f0 View commit details
    Browse the repository at this point in the history
  4. ProcessWatchdogTest: only check exit code 259 on Windows

    This code is out of range of valid exit codes on Unix anyway.
    ForNeVeR committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    ef45bfa View commit details
    Browse the repository at this point in the history