Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding = operator to ENV assignments #1084

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

matentzn
Copy link
Contributor

During the last runs of docker build I got a warning "- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line X)", which is due to the fact that the "equal-less form is deprecated and may be removed in the future" (thanks @gouttegd for the note). Here I add equal signs to all such cases across the project.

During the last runs of docker build I got a warning "- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line X)", which is due to the fact that the "equal-less form is deprecated and may be removed in the future" (thanks @gouttegd for the note). Here I add equal signs to all such cases across the project.
@matentzn matentzn requested a review from gouttegd July 16, 2024 08:55
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the meaningful commit message, appreciated.

@matentzn matentzn merged commit 7d8310a into master Jul 18, 2024
1 check passed
@matentzn matentzn deleted the add-equal-signs-dockerfile branch July 18, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants