Skip to content

Commit

Permalink
Merge pull request #1084 from INCATools/add-equal-signs-dockerfile
Browse files Browse the repository at this point in the history
Adding = operator to ENV assignments
  • Loading branch information
matentzn authored Jul 18, 2024
2 parents 3b8504b + 1261d20 commit 7d8310a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ ARG ODKLITE_TAG=latest
FROM obolibrary/odklite:${ODKLITE_TAG}
LABEL maintainer="[email protected]"

ENV PATH "/tools/apache-jena/bin:/tools/sparqlprog/bin:$PATH"
ENV PATH="/tools/apache-jena/bin:/tools/sparqlprog/bin:$PATH"

ARG ODK_VERSION 0.0.0
ENV ODK_VERSION $ODK_VERSION
ENV ODK_VERSION=$ODK_VERSION

# Software versions
ENV JENA_VERSION=4.9.0
Expand All @@ -16,7 +16,7 @@ ENV SSSOM_JAVA_VERSION=0.7.7

# Avoid repeated downloads of script dependencies by mounting the local coursier cache:
# docker run -v $HOME/.coursier/cache/v1:/tools/.coursier-cache ...
ENV COURSIER_CACHE "/tools/.coursier-cache"
ENV COURSIER_CACHE="/tools/.coursier-cache"

# Add NodeSource package repository (needed to get recent versions of Node)
COPY thirdpartykeys/nodesource.gpg /usr/share/keyrings/nodesource.gpg
Expand Down Expand Up @@ -103,7 +103,7 @@ RUN chmod +x /tools/obodash && \

# Install relation-graph
ENV RG=2.3.2
ENV PATH "/tools/relation-graph/bin:$PATH"
ENV PATH="/tools/relation-graph/bin:$PATH"
RUN wget -nv https://github.com/balhoff/relation-graph/releases/download/v$RG/relation-graph-cli-$RG.tgz \
&& tar -zxvf relation-graph-cli-$RG.tgz \
&& mv relation-graph-cli-$RG /tools/relation-graph \
Expand Down
6 changes: 3 additions & 3 deletions docker/robot/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ LABEL maintainer="[email protected]"

WORKDIR /tools

ENV ROBOT v1.9.6
ENV ROBOT=v1.9.6
ARG ROBOT_JAR=https://github.com/ontodev/robot/releases/download/$ROBOT/robot.jar
ENV ROBOT_JAR ${ROBOT_JAR}
ENV ROBOT_JAR=${ROBOT_JAR}

RUN apt-get update &&\
apt-get upgrade -y &&\
Expand All @@ -20,6 +20,6 @@ RUN curl -L $ROBOT_JAR -o /tools/robot.jar &&\
chmod +x /tools/robot && \
chmod +x /tools/robot.jar

ENV PATH "/tools/:$PATH"
ENV PATH="/tools/:$PATH"
RUN echo "Keep me in sync with obolibrary/odkfull!"
CMD robot -h

0 comments on commit 7d8310a

Please sign in to comment.