Add international edition to ODK #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to pass them in the jinja template, and extensible in case in the future they become something other than boolean.
gouttegd
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Not much to review since most of the actual work is done by Babelon, which I did not review.
Two concerns: 1) reference to an OPENAI_API_KEY out of the blue (how are users supposed to communicate that key), and 2) theft that “auto translate” relies on LLM services must be explicitly documented.
This includes - Failing hard when OPENAI KEY is not set - Fixing a bug in a line break
gouttegd
previously approved these changes
Feb 29, 2024
declare oak adapter fields in data classes.
|
@gouttegd sorry there was a small bug, its done now. :/ I will merge once QC passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a monster. It was fun to do it, and it took me more than 10 hours to write.. There will probably be issues here and there - a review should probably focus on the places where the change affects previous parts of the code. I did some extensive testing, but I am still on it a bit.