-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add international edition to ODK #1006
Conversation
This makes it easier to pass them in the jinja template, and extensible in case in the future they become something other than boolean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to review since most of the actual work is done by Babelon, which I did not review.
Two concerns: 1) reference to an OPENAI_API_KEY
out of the blue (how are users supposed to communicate that key), and 2) theft that “auto translate” relies on LLM services must be explicitly documented.
This includes - Failing hard when OPENAI KEY is not set - Fixing a bug in a line break
declare oak adapter fields in data classes.
@gouttegd sorry there was a small bug, its done now. :/ I will merge once QC passes. |
This PR is a monster. It was fun to do it, and it took me more than 10 hours to write.. There will probably be issues here and there - a review should probably focus on the places where the change affects previous parts of the code. I did some extensive testing, but I am still on it a bit.