-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations: Bugfix, drop columns, new defaults #1019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but please see my remarks about the use of a string-typed parameter in the config file (both for the newly added drop_unknown_columns
and the other parameters added in #1006). They should really be boolean parameters.
(I am not requesting any change since it’s my fault for not having caught this mistyping before. Your call whether you want to change the type or not.)
Thank you, I also tested your suggestion and it works perfect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad that you agreed with the proposed change, but then it should be done correctly. It’s not enough to assign a default value of True
or False
– the option itself needs to be declared as bool
. Otherwise you’re merely declaring a string-typed option that happens to have a default value of True
or False
.
This PR: