Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seed fixing option to PySMO's sampling methods to enhance reproducibility #1307
Add seed fixing option to PySMO's sampling methods to enhance reproducibility #1307
Changes from 26 commits
3362cd3
2368de9
66b37e4
d627e68
ab087b6
81c3c3e
7bb0310
2eadf88
2a952a0
1efb59c
741865a
cdde009
879d720
6920ce3
87588ba
1bd7d3d
429dcc4
d54f592
fd9b7d1
dc4de4c
1e00f62
9f36da4
870cad1
361077c
9fcb8c3
3af1da5
e2fa3c6
93cde23
59d7d9e
2477b3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as this is in
__init__
, should this code be moved to the base class to avoid duplicating the code in each subclass?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'd rather leave it here because it is an argument specific to a subset of the sampling methods.