Add seed fixing option to PySMO's sampling methods to enhance reproducibility #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- User can explicitly define a distribution for sampling of each variable. Sampling options currently available are random, uniform and Gaussian.
OOAmusat
requested review from
andrewlee94,
carldlaird and
bpaul4
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 390 390
Lines 63631 63649 +18
Branches 11702 11705 +3
=======================================
+ Hits 49258 49273 +15
- Misses 11835 11839 +4
+ Partials 2538 2537 -1 ☔ View full report in Codecov by Sentry. |
andrewlee94
reviewed
Dec 19, 2023
| @@ -1412,6 +1422,12 @@ def __init__( | |||
| raise Exception("Invalid tolerance input") | |||
| self.eps = tolerance | |||
|
|
|||
| if rand_seed is not None: | |||
There was a problem hiding this comment.
Seeing as this is in __init__, should this code be moved to the base class to avoid duplicating the code in each subclass?
There was a problem hiding this comment.
No, I'd rather leave it here because it is an argument specific to a subset of the sampling methods.
bpaul4
reviewed
Jan 11, 2024
bpaul4
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR adds the ability for users to specify a seed with
rand_seedwhen using theLatinHypercubeSampling,CVTSamplingandCustomSamplingclasses in PySMO. Fixingrand_seedensures that the sampling methods return the same results every time the methods are run, allowing for reproducibility.Changes proposed in this PR:
rand_seedargument to CVT, LHS and custom sampling methodsLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: