Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solid-Liquid Separator Base Model #1283
Solid-Liquid Separator Base Model #1283
Changes from 5 commits
47ae9d8
4d0410a
a0357d5
5ee9a57
6be8f78
a1b5ffb
a2cc609
43feefe
3857afb
a59d726
a1999a9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think the "and" is necessary in this list. People might assume that some text is supposed to follow but is just missing
Check warning on line 928 in idaes/models/unit_models/mscontactor.py
Codecov / codecov/patch
idaes/models/unit_models/mscontactor.py#L928
Check warning on line 930 in idaes/models/unit_models/mscontactor.py
Codecov / codecov/patch
idaes/models/unit_models/mscontactor.py#L930