Solid-Liquid Separator Base Model #1283
Conversation
|
@adam-a-a You might want to be aware of this for potential use in WaterTAP. |
andrewlee94
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1283 +/- ##
==========================================
+ Coverage 77.25% 77.27% +0.01%
==========================================
Files 387 389 +2
Lines 63127 63217 +90
Branches 11613 11624 +11
==========================================
+ Hits 48768 48850 +82
- Misses 11837 11844 +7
- Partials 2522 2523 +1
☔ View full report in Codecov by Sentry. |
andrewlee94
requested review from
eslickj,
lbianchi-lbl and
ksbeattie
as code owners
docs/reference_guides/model_libraries/generic/unit_models/solid_liquid/index.rst
Outdated
Show resolved
Hide resolved
|
|
||
| @pytest.mark.component | ||
| def test_structural_issues(self, model): | ||
| dt = DiagnosticsToolbox(model) |
There was a problem hiding this comment.
Is this going to be standard procedure for tests now? I like it; I'm just asking.
There was a problem hiding this comment.
The idea is that we will add this to all the model tests (as well as doing parameter sweeps with numerical checks as part of the compatibility/verification testing too).
| * ``solid_inlet`` representing the solids in the incoming stream, | ||
| * ``liquid_inlet`` representing the liquid in the incoming stream, | ||
| * ``solid_outlet`` representing the solids in the concentrated stream, | ||
| * ``retained_liquid_outlet`` representing the liquid in the concentrated stream, and, |
There was a problem hiding this comment.
| * ``retained_liquid_outlet`` representing the liquid in the concentrated stream, and, | |
| * ``retained_liquid_outlet`` representing the liquid in the concentrated stream |
Don't think the "and" is necessary in this list. People might assume that some text is supposed to follow but is just missing
|
@MarcusHolly @agarciadiego Would you be able to take a quick look at this again? I added a basic thickener model which derives from the SLSeparator. |
docs/reference_guides/model_libraries/generic/unit_models/solid_liquid/thickener0d.rst
Outdated
Show resolved
Hide resolved
LGTM |
LGTM |
Fixes #1218 amongst other things
Summary/Motivation:
This PR adds a new unit model base class for separating solids and liquids such as filters and thickeners. The unit has two inlets (solid and liquid) and three outlets (solids, retained_liquid (with solids) and recovered liquid).
Docs to come, along with a derived model for thickeners.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: