Fix numpy random seed for PySMO test #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OOAmusat
requested review from
andrewlee94,
carldlaird and
bpaul4
as code owners
OOAmusat
requested review from
dangunter and
lbianchi-lbl
and removed request for
andrewlee94,
carldlaird and
bpaul4
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
- Coverage 76.73% 76.72% -0.01%
==========================================
Files 382 382
Lines 61232 61232
Branches 11297 11297
==========================================
- Hits 46985 46982 -3
- Misses 11813 11817 +4
+ Partials 2434 2433 -1 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
lbianchi-lbl
approved these changes
Sep 8, 2023
lbianchi-lbl
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Minor change to trigger tests * Added abs to tolerance check * Run black * Remove string comparison * Tighten tolerance * Fixed kriging test by removing variable dependence * Fixing random seed for kriging test (cherry picked from commit 02c20ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#1258
Summary/Motivation:
A possible spurious failure was observed in one run of trhe PySMO kriging test (#1258). The error is due to random number generation with numpy, so this change aims to fix the seed for that specific test.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: