Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible spurious failure in Pysmo kriging tests #1258

Closed
lbianchi-lbl opened this issue Aug 31, 2023 · 3 comments · Fixed by #1264
Closed

Possible spurious failure in Pysmo kriging tests #1258

lbianchi-lbl opened this issue Aug 31, 2023 · 3 comments · Fixed by #1264
Assignees
Labels
Priority:Normal Normal Priority Issue or PR

Comments

@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Aug 31, 2023

This occurred in https://github.com/IDAES/idaes-pse/actions/runs/6041051733 for a single job run and seems unrelated to #1253.

image

@lbianchi-lbl lbianchi-lbl changed the title Possible spurious failures in Pysmo tests Possible spurious failures in Pysmo kriging tests Aug 31, 2023
@lbianchi-lbl lbianchi-lbl changed the title Possible spurious failures in Pysmo kriging tests Possible spurious failure in Pysmo kriging tests Aug 31, 2023
@andrewlee94
Copy link
Member

The Pysomo tests are known to have an issue with non-deterministic behavior. Specifically, I think it is because the sampling steps are not seeded and thus we get a new set of sample points each time we run the tests and occasionally this results in an infeasible solution.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 7, 2023
@ksbeattie
Copy link
Member

@OOAmusat would this be easy/possible to fix as well?

@OOAmusat
Copy link
Contributor

OOAmusat commented Sep 7, 2023

@lbianchi-lbl @ksbeattie This is due to random number generation with NumPy/SciPy in the initialization and solution steps.

I have attempted to fix the issue by fixing the numpy random seed generator for this test (PR #1264), but since it is a random failure there is no way to know if the fix works.

@OOAmusat OOAmusat linked a pull request Sep 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants