Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformulate solubility_products constraints #1197

Merged
merged 23 commits into from
Jul 27, 2023

Merge branch 'main' into chem_init

14cb740
Select commit
Loading
Failed to load commit list.
Merged

Reformulate solubility_products constraints #1197

Merge branch 'main' into chem_init
14cb740
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 27, 2023 in 0s

76.83% (-0.01%) compared to ad5b8ad

View this Pull Request on Codecov

76.83% (-0.01%) compared to ad5b8ad

Details

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.01% ⚠️

Comparison is base (ad5b8ad) 76.84% compared to head (14cb740) 76.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.01%     
==========================================
  Files         390      390              
  Lines       61875    61885      +10     
  Branches    11389    11391       +2     
==========================================
+ Hits        47547    47552       +5     
- Misses      11866    11871       +5     
  Partials     2462     2462              
Files Changed Coverage Δ
.../modular_properties/reactions/equilibrium_forms.py 87.21% <84.61%> (-0.59%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.