Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformulate solubility_products constraints #1197

Merged
merged 23 commits into from
Jul 27, 2023
Merged

Reformulate solubility_products constraints #1197

merged 23 commits into from
Jul 27, 2023

Commits on May 26, 2023

  1. Modified log_solubility_product function to accomodate the comparison… 

    … betweem s and Q.

Modified bounds of mole_frac_phase_comp to be consistent with those of log_mole_frac_phase_comp
    Xinhong Liu committed May 26, 2023
    Configuration menu
    Copy the full SHA
    513796e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Remove comments

    Xinhong Liu committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    517c0a1 View commit details
    Browse the repository at this point in the history

  2. run black

    @bknueven
    bknueven committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    6463f3b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Update state_difinitions vars lower bouds

    Liu committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c940637 View commit details
    Browse the repository at this point in the history

  2. Add mutable parameters for reformated solubility_product

    Liu committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    99db9c3 View commit details
    Browse the repository at this point in the history

  3. Update solubility_product tests

    Liu committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2b58efa View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Merge branch 'main' into chem_init

    @andrewlee94
    andrewlee94 authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1edee16 View commit details
    Browse the repository at this point in the history

  2. test_plate_heat_exchanger.py 

    Remove initialization opts after updating bounds in state_difinitions
    Liu committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d5b2aa3 View commit details
    Browse the repository at this point in the history

  3. run black

    Liu committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d598545 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Reverse changes for lower bounds in state_definition

    Liu committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    28aed85 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into chem_init

    @andrewlee94
    andrewlee94 authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    6eee6b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Add assertion for default s_norm and a_scale checking

    Liu committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    4cd060d View commit details
    Browse the repository at this point in the history

  2. Typo corrected

    Liu committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d6462cd View commit details
    Browse the repository at this point in the history

  3. Add documentation for solubility_product

    @lxhowl
    lxhowl authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    89b6a2f View commit details
    Browse the repository at this point in the history

  4. Update doc string

    Liu committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    a990507 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'IDAES:main' into chem_init

    @lxhowl
    lxhowl authored Jun 20, 2023
    Configuration menu
    Copy the full SHA
    d42a687 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Equation corrected for sulubility product doc

    Liu committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5306d36 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge branch 'IDAES:main' into chem_init

    @lxhowl
    lxhowl authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    4ca5c87 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge branch 'main' into chem_init

    @lbianchi-lbl
    lbianchi-lbl authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e4a6376 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Switch to set_value for default s_norm

    Liu committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bc88595 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Scaling applied in subsaturated cases (low concentrations) to use def… 

    …ault solver options
    Liu committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    214f14f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Run black

    Liu committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7bec453 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge branch 'main' into chem_init

    @andrewlee94
    andrewlee94 authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    14cb740 View commit details
    Browse the repository at this point in the history