Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create plotly versions of selected matplotlib visualizations #610

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

yannikschaelte
Copy link
Member

  • Focusing on (most of) the most relevant visualization methods
  • To be extended by demand

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #610 (7f241e6) into develop (604a443) will decrease coverage by 43.22%.
The diff coverage is 12.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop     #610       +/-   ##
============================================
- Coverage    84.09%   40.88%   -43.22%     
============================================
  Files          140      140               
  Lines         8193     8495      +302     
============================================
- Hits          6890     3473     -3417     
- Misses        1303     5022     +3719     
Files Coverage Δ
pyabc/visualization/__init__.py 100.00% <100.00%> (ø)
pyabc/transition/jump.py 24.61% <0.00%> (-67.70%) ⬇️
pyabc/visualization/util.py 15.09% <23.07%> (-79.91%) ⬇️
pyabc/visualization/model_probabilities.py 23.33% <17.64%> (-76.67%) ⬇️
pyabc/visualization/epsilon.py 23.40% <16.66%> (-70.35%) ⬇️
pyabc/visualization/effective_sample_size.py 20.00% <12.12%> (-74.60%) ⬇️
pyabc/visualization/credible.py 7.58% <3.17%> (-88.21%) ⬇️
pyabc/visualization/kde.py 10.69% <10.63%> (-86.85%) ⬇️
pyabc/visualization/walltime.py 12.94% <13.20%> (-75.67%) ⬇️
pyabc/visualization/sample.py 8.62% <11.21%> (-88.78%) ⬇️

... and 76 files with indirect coverage changes

Copy link
Collaborator

@stephanmg stephanmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@arrjon arrjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@stephanmg stephanmg merged commit 46ef9ae into develop Nov 8, 2023
11 checks passed
stephanmg added a commit that referenced this pull request Nov 10, 2023
* Fix assets for pyabc visserver.

* Update R.

* Fix for logo path in abc-server-dash

* Preparing release notes for next patch release.

* Updating about.rst.

* Updating changelog.

* Create plotly versions of selected matplotlib visualizations (#610)

* Create ploty versions of selected matplotlib visualizations

* update r install instructions

* fix pandas float deprecation warnings

* fixarray ndim > 0 float extraction deprecationwarning

---------

Co-authored-by: Stephan Grein <[email protected]>

* add the functionality to evaluate the model using boundry values of p… (#355)

* add the functionality to evaluate the model using boundry values of parameter

* fix flake8 issues

* fix additional flake8 issues

* add test case

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* black fixes

* Update test_external.py

Use correct comparison operator.

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Emad Alamoudi <[email protected]>
stephanmg added a commit that referenced this pull request Nov 10, 2023
* Fix assets for pyabc visserver.

* Update R.

* Fix for logo path in abc-server-dash

* Preparing release notes for next patch release.

* Updating about.rst.

* Updating changelog.

* Create plotly versions of selected matplotlib visualizations (#610)

* Create ploty versions of selected matplotlib visualizations

* update r install instructions

* fix pandas float deprecation warnings

* fixarray ndim > 0 float extraction deprecationwarning

---------

Co-authored-by: Stephan Grein <[email protected]>

* add the functionality to evaluate the model using boundry values of p… (#355)

* add the functionality to evaluate the model using boundry values of parameter

* fix flake8 issues

* fix additional flake8 issues

* add test case

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* black fixes

* Update test_external.py

Use correct comparison operator.

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Emad Alamoudi <[email protected]>
stephanmg added a commit that referenced this pull request Nov 15, 2023
* Fix assets for pyabc visserver.

* Update R.

* Fix for logo path in abc-server-dash

* Preparing release notes for next patch release.

* Updating about.rst.

* Updating changelog.

* Create plotly versions of selected matplotlib visualizations (#610)

* Create ploty versions of selected matplotlib visualizations

* update r install instructions

* fix pandas float deprecation warnings

* fixarray ndim > 0 float extraction deprecationwarning

---------

Co-authored-by: Stephan Grein <[email protected]>

* add the functionality to evaluate the model using boundry values of p… (#355)

* add the functionality to evaluate the model using boundry values of parameter

* fix flake8 issues

* fix additional flake8 issues

* add test case

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* flake8 fixes

* black fixes

* Update test_external.py

Use correct comparison operator.

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>
Co-authored-by: Stephan Grein <[email protected]>

* Fix extra dependencies.

---------

Co-authored-by: Yannik Schälte <[email protected]>
Co-authored-by: Emad Alamoudi <[email protected]>
Co-authored-by: Jonas Arruda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants