Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a PermissionManager core module #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement a PermissionManager core module #116

wants to merge 4 commits into from

Commits on Oct 1, 2018

  1. halauth: return True/False based on if grant/revoke operation succeeded

    @richteer
    richteer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    1898759 View commit details
    Browse the repository at this point in the history

  2. halauth: simplify dependencies for the hasPermission decorator 

    The `@hasPermission` decorator was intended to be simple to use for module
developers. As it turns out however, it is completely incompatible with modules
that subclass CommandModule. Considering this is also a class intended to make
life easier, something had to be fixed.

Thus, a compromise was reached: have the decorator search for the `Message`
object *somewhere* in the target function's parameters. Rather than require it
to be the first positional argument, it will instead use the identity/ri
information from the *first* `Message` object in the parameter list.
    @richteer
    richteer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    fe3cfc2 View commit details
    Browse the repository at this point in the history

  3. CI: update tests for changes to halauth

    @richteer
    richteer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    f4a4898 View commit details
    Browse the repository at this point in the history

  4. packages/core: add permission management module 

    Permissions have been long ignored in Halibot, largely because there hasn't
been a convenient way to manipulate them. This commit adds a core module
to expose some commands for runtime permission management.
    @richteer
    richteer committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    6f62e03 View commit details
    Browse the repository at this point in the history