Implement a PermissionManager core module #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@hasPermission` decorator was intended to be simple to use for module developers. As it turns out however, it is completely incompatible with modules that subclass CommandModule. Considering this is also a class intended to make life easier, something had to be fixed. Thus, a compromise was reached: have the decorator search for the `Message` object *somewhere* in the target function's parameters. Rather than require it to be the first positional argument, it will instead use the identity/ri information from the *first* `Message` object in the parameter list.
Permissions have been long ignored in Halibot, largely because there hasn't been a convenient way to manipulate them. This commit adds a core module to expose some commands for runtime permission management.
richteer
force-pushed
the
core-perm-module
branch
from
04011ef
to
6f62e03
Compare
sjrct
requested changes
Oct 7, 2019
| def wrapper(self, *args, **kwargs): | ||
| msg = None | ||
| for i in list(args) + list(kwargs.values()): | ||
| if i.__class__ == Message: |
There was a problem hiding this comment.
What about subclasses of Message? I think we should be checking for those too.
There was a problem hiding this comment.
Yes, it should be checking if the class chain has Message.
|
|
||
| t = (ri, identity, perm) | ||
| if t not in self.perms: | ||
| self.perms.append(t) | ||
| return True | ||
| return False |
There was a problem hiding this comment.
NB: Should we raise an exception here instead of returning false?
There was a problem hiding this comment.
Probably. I have a lot of return bools in here, most of those should probably be exceptions. Too much C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissions have been long ignored in Halibot, largely because there hasn't been a convenient way to manipulate them. This commit adds a core module to expose some commands for runtime permission management.
There is a bit of a chicken-and-egg problem with this, as you need to grant yourself the permission to edit permissions first. This is a prime candidate for a future CLI-enabled module, but I figured it was better to release this first while #113 is still up in the air.
This branch depends on #115 , since it needs the fixed decorator thanks to the previous implementation's incompatibility with
CommandModule.Question: Should
PERM_GRANTandPERM_REVOKEbe merged into a singlePERM_EDITpermission?