Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement module-theta readout (with per-layer merging) #48

Merged

Conversation

giovannimarchiori
Copy link
Contributor

@giovannimarchiori giovannimarchiori commented Aug 28, 2023

This code implements the cell positioning calculations for the module-theta merged readout implemented in HEP-FCC/FCCDetectors#56

Tagging @gartrog , @BrieucF

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 21, 2023

Hi @giovannimarchiori,
since the new way how to calculate cell positions guts the original tool, would it be possible to instead create a new one? The interface for the cell positioning tools is defined in ICellPositionsTool.h.

@giovannimarchiori
Copy link
Contributor Author

Hi @kjvbrt ,
could please elaborate more? I don't understand exactly what's the problem here. I took a code that was working only for a specific readout (eta-phi) and made it more general (not it works for eta-phi but also for theta-phi and for the theta-module merged readout). Are you saying it's better instead to have separate cell position tools for different readout so that each tool is easier to understand ? In that case, I can create a new tool CellPositionsECalBarrelFCCeeTool (or something like that) in RecFCCeeCalorimeter

@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 21, 2023

Yes, to have different tools for different readouts, this way the change is visible in the steering file.

@giovannimarchiori
Copy link
Contributor Author

Hi @kjvbrt ,
I created a new tool as you suggested

@kjvbrt kjvbrt merged commit c71ffad into HEP-FCC:main Sep 26, 2023
1 check failed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-ModuleThetaReadout branch April 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants