Implement module-theta readout (with per-layer merging) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2023
BrieucF
reviewed
Sep 21, 2023
There was a problem hiding this comment.
This is an extremely useful feature to have for detector optimization, thanks a lot @giovannimarchiori !
Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml
Outdated
Show resolved
Hide resolved
Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml
Outdated
Show resolved
Hide resolved
Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml
Show resolved
Hide resolved
Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml
Show resolved
Hide resolved
Detector/DetFCCeeECalInclined/compact/FCCee_ECalBarrel_thetamodulemerged.xml
Show resolved
Hide resolved
BrieucF
reviewed
Sep 21, 2023
|
Perfect, thanks! This will be merged at the same time as HEP-FCC/k4SimGeant4#46 and HEP-FCC/k4RecCalorimeter#48 |
…fig but could be used to enforce that length of vector passed via xml to configure merging per layer is correct
atolosadelgado
added a commit
to atolosadelgado/k4geo
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code implements a readout for the ECAL with inclined electrodes based on module number and theta ID, with the possibility to group adjacent cells (in theta and or in module direction) together.
See my presentation here: https://indico.cern.ch/event/1299615/contributions/5475445/attachments/2679458/4647792/2023_07_06%20-%20Noble%20liquid%20calorimeter%20digitisation.pdf
Tagging @gartrog , @BrieucF