Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update infisical-secrets-check.yml #25

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Update infisical-secrets-check.yml #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/infisical-secrets-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ jobs:

secrets-scan:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:

- name: Checkout repo
Comment on lines 12 to 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE REVIEW

Adding permissions is crucial for security compliance. Here are two improvements:

  1. Explicit Permissions:
    Define the exact permissions needed. Scopes such as pull-requests: write might be too broad.
permissions:
  contents: read
  pull-requests: write  # Confirm this is necessary
  1. Comments for Clarity:
    Comment why each permission is needed for future reference.
permissions:
  contents: read  # Required to read repository content
  pull-requests: write  # Required for pull request modifications

Expand Down
Loading