Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx Large Miner not working with ME Output Bus and working area text with screwdriver while not in Chunk Mode #2513

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FIx Large Miner not working with ME Output Bus and working area text with screwdriver while not in Chunk Mode #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be15e5f
fix me output bus
Synthitic Jul 2, 2024
ce740da
fix screwdriver text not in chunk mode
Synthitic Jul 2, 2024
ba29b7f
oops
Synthitic Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/gregtech/api/capability/impl/miner/MinerLogic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ private void mineAndInsertItems(NonNullList<ItemStack> blockDrops, WorldServer w
// If the block's drops can fit in the inventory, move the previously mined position to the block
// replace the ore block with cobblestone instead of breaking it to prevent mob spawning
// remove the ore block's position from the mining queue
if (GTTransferUtils.addItemsToItemHandler(metaTileEntity.getExportItems(), true, blockDrops)) {
if (GTTransferUtils.addItemsToItemHandler(metaTileEntity.getExportItems(), true, blockDrops) ||
metaTileEntity.getExportItems().getSlotLimit(0) == Integer.MAX_VALUE - 1) { // Check for ME Output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this result in voiding?

Also why does the ME output bus work with AbstractRecipeLogic but not here? They both do the same check with the same method.

GTTransferUtils.addItemsToItemHandler(metaTileEntity.getExportItems(), false, blockDrops);
world.setBlockState(blocksToMine.getFirst(), oreReplacementBlock);
mineX.set(blocksToMine.getFirst().getX());
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/gregtech/common/metatileentities/multi/electric/MetaTileEntityLargeMiner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ public boolean onScrewdriverClick(EntityPlayer playerIn, EnumHand hand, EnumFaci
this.minerLogic.setCurrentRadius(currentRadius - CHUNK_LENGTH / 2);
}
int workingArea = getWorkingArea(minerLogic.getCurrentRadius());
playerIn.sendMessage(new TextComponentTranslation("gregtech.universal.tooltip.working_area",
playerIn.sendMessage(new TextComponentTranslation("gregtech.machine.miner.working_area",
workingArea, workingArea));
}
this.minerLogic.resetArea();
Expand Down
Loading