FIx Large Miner not working with ME Output Bus and working area text with screwdriver while not in Chunk Mode #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthitic
changed the title
ALongStringOfNumbers
approved these changes
Jul 3, 2024
TechLord22
reviewed
Jul 5, 2024
| @@ -282,7 +282,8 @@ private void mineAndInsertItems(NonNullList<ItemStack> blockDrops, WorldServer w | |||
| // If the block's drops can fit in the inventory, move the previously mined position to the block | |||
| // replace the ore block with cobblestone instead of breaking it to prevent mob spawning | |||
| // remove the ore block's position from the mining queue | |||
| if (GTTransferUtils.addItemsToItemHandler(metaTileEntity.getExportItems(), true, blockDrops)) { | |||
| if (GTTransferUtils.addItemsToItemHandler(metaTileEntity.getExportItems(), true, blockDrops) || | |||
| metaTileEntity.getExportItems().getSlotLimit(0) == Integer.MAX_VALUE - 1) { // Check for ME Output | |||
There was a problem hiding this comment.
Can this result in voiding?
Also why does the ME output bus work with AbstractRecipeLogic but not here? They both do the same check with the same method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The large miner would say its inventory was full when using ME Output bus despite it having infinite size.
Using the screwdriver when it was not in chunk mode would give an unlocalized string.
Implementation Details
Adds a check by slot limit. The implementation of having a method in IMiner to retrieve a stored boolean has little to no performance difference in my testing.
Changes the translation key to the right one.
Outcome
Fixes #2476
Fixes #2473
Additional Information
None
Potential Compatibility Issues
None to my knowledge.