Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map faas.* attributes to generic task after service.name, but ignore unknown_service #764

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Nov 1, 2023

Fixes #735

Also, fixes the mapping logic to use faas.instance instead of faas.id.

The logic is modeled after GoogleCloudPlatform/opentelemetry-operations-python#273

@dashpole dashpole requested a review from a team as a code owner November 1, 2023 16:21
@dashpole dashpole added the enhancement New feature or request label Nov 1, 2023
@dashpole dashpole requested a review from aabmass November 1, 2023 16:22
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #764 (5f8d43a) into main (2f06d89) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   69.65%   69.68%   +0.02%     
==========================================
  Files          42       42              
  Lines        4845     4859      +14     
==========================================
+ Hits         3375     3386      +11     
- Misses       1321     1323       +2     
- Partials      149      150       +1     
Files Coverage Δ
exporter/metric/option.go 57.89% <ø> (ø)
...ector/googlemanagedprometheus/monitoredresource.go 92.30% <93.33%> (-7.70%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@dashpole
Copy link
Contributor Author

dashpole commented Nov 2, 2023

@aabmass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map faas.* attributes to generic_task in resource mapping
2 participants