otel-collector config to populate FAAS name #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Tran <[email protected]>
imjasonh
approved these changes
Dec 24, 2023
|
nice :) |
tcnghia
added a commit
that referenced
this pull request
Dec 24, 2023
This makes use of what we added in #42 Signed-off-by: Nghia Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gcpresource detection plugin populates the attributefaas.nameto Cloud Run Service/Job, and Cloud Function name, which makes it a nice way to standardize on naming (see). Using env var is less convenient for this purpose because Cloud Run Service name is$K_SERVICEand for Cloud Run Job it's$CLOUD_RUN_JOB.The googlemanagedprometheus exporter consumes
service.nameattribute and create a resource label namedjobwith this value when uploading metrics. There is no customization of this. (see).This PR plumbs
faas.nameintoservice.nameso we can get a resource label with the Cloud Run Service or Job name on all our exported metrics. Also droppinginstance idbecause this is an unbounded dimension, and even worse when a lot of scaling-to-zero happens.