Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rendering): skip null renderable grids #957

Merged
merged 1 commit into from
Feb 11, 2024
Merged

fix(rendering): skip null renderable grids #957

merged 1 commit into from
Feb 11, 2024

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Feb 11, 2024 •
edited
Loading

Description

Closes #956

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Feb 11, 2024
@RiscadoA RiscadoA self-assigned this Feb 11, 2024
@RiscadoA RiscadoA linked an issue Feb 11, 2024 that may be closed by this pull request
Renderable Grid component with a null asset crashes the engine #956
Closed
@RiscadoA RiscadoA merged commit d70d953 into main Feb 11, 2024
9 checks passed
@RiscadoA RiscadoA deleted the 956-renderable-grid-component-with-a-null-asset-crashes-the-engine branch February 11, 2024 13:04
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.7
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-957/
on branch gh-pages at 2024-02-11 13:05 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RiscadoA RiscadoA

Labels
A-Engine B-Rendering C-Crash
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging this pull request may close these issues.

Renderable Grid component with a null asset crashes the engine
1 participant
@RiscadoA