Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderable Grid component with a null asset crashes the engine #956

Closed
RiscadoA opened this issue Feb 11, 2024 · 0 comments · Fixed by #957
Closed

Renderable Grid component with a null asset crashes the engine #956

RiscadoA opened this issue Feb 11, 2024 · 0 comments · Fixed by #957
Assignees
@RiscadoA
Labels
A-Engine B-Rendering C-Crash
Milestone
0.1 Jammable Engine

Comments

@RiscadoA
Copy link
Member

Description

When you add a RenderableGrid component to an entity with a null asset handle (which is the default value), the engine crashes.

Expected behaviour

It should just not show a grid.
@RiscadoA RiscadoA added this to the 0.1 Jammable Engine milestone Feb 11, 2024
@RiscadoA RiscadoA self-assigned this Feb 11, 2024
RiscadoA added a commit that referenced this issue Feb 11, 2024
@RiscadoA
fix(rendering): skip null renderable grids
54c4e9d 
Closes #956
RiscadoA added a commit that referenced this issue Feb 11, 2024
@RiscadoA
fix(rendering): skip null renderable grids
a17bb8b 
Closes #956
@RiscadoA RiscadoA mentioned this issue Feb 11, 2024
Merged
5 tasks
@RiscadoA RiscadoA linked a pull request Feb 11, 2024 that will close this issue
fix(rendering): skip null renderable grids #957
Merged
5 tasks
RiscadoA added a commit that referenced this issue Feb 11, 2024
@RiscadoA
fix(rendering): skip null renderable grids
d70d953 
Closes #956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RiscadoA RiscadoA

Labels
A-Engine B-Rendering C-Crash
Projects
None yet
Milestone
0.1 Jammable Engine
Development

Successfully merging a pull request may close this issue.

fix(rendering): skip null renderable grids GameDevTecnico/cubos
1 participant
@RiscadoA