-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate screenPickerPlugin with gizmosPlugin #938
Integrate screenPickerPlugin with gizmosPlugin #938
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
+ Coverage 34.43% 34.46% +0.03%
==========================================
Files 283 283
Lines 23710 23687 -23
==========================================
Hits 8164 8164
+ Misses 15546 15523 -23 ☔ View full report in Codecov by Sentry. |
66778c0
to
98b8b70
Compare
No Clang-Tidy warnings found so I assume my comments were addressed
98b8b70
to
2df0609
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn that was fast 👀 Thanks for working on this! The code LGTM, also ran it locally, it did fix that bug where clicking the transform gizmo deselected the entity. Feel free to merge
2df0609
to
48ef38f
Compare
Description
Changes gizmosPlugin to store gizmo ids in screenPickerPlugin instead of a separate buffer.
Checklist