Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define reflection for primitive types #543

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Sep 13, 2023

Description

Implement reflection for boolean, char, integer and floating point types.

Checklist

  • Self-review changes.
  • Ensure test coverage.

@RiscadoA RiscadoA added A-Core B-Reflection S-Blocked Blocked on another issue or PR labels Sep 13, 2023
@RiscadoA RiscadoA added this to the 0.0 Nursery milestone Sep 13, 2023
@RiscadoA RiscadoA self-assigned this Sep 13, 2023
@RiscadoA RiscadoA linked an issue Sep 13, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-19 21:47 UTC

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (456ae3b) 25.22% compared to head (a842228) 25.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   25.22%   25.34%   +0.12%     
==========================================
  Files          93       94       +1     
  Lines        7219     7231      +12     
==========================================
+ Hits         1821     1833      +12     
  Misses       5398     5398              
Files Changed Coverage Δ
.../src/cubos/core/reflection/external/primitives.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 13, 2023
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Sep 19, 2023
@RiscadoA RiscadoA force-pushed the 538-define-reflection-for-primitive-types branch from accbd08 to a842228 Compare September 19, 2023 19:48
@RiscadoA RiscadoA merged commit 4711c24 into main Sep 19, 2023
8 checks passed
@RiscadoA RiscadoA deleted the 538-define-reflection-for-primitive-types branch September 19, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define reflection for primitive types
2 participants