Add FieldsTrait
#544
Merged
Add FieldsTrait
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 26.92% 27.67% +0.75%
==========================================
Files 89 91 +2
Lines 6797 6872 +75
==========================================
+ Hits 1830 1902 +72
- Misses 4967 4970 +3
☔ View full report in Codecov by Sentry. |
RiscadoA
force-pushed
the
482-add-fieldstrait
branch
from
c2ee568
to
2d42254
Compare
luishfonseca
requested changes
Sep 25, 2023
RiscadoA
requested review from
luishfonseca
and removed request for
luishfonseca
RiscadoA
force-pushed
the
482-add-fieldstrait
branch
from
c961083
to
b1309db
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
dismissed stale reviews from themself
No clang-tidy warnings found so I assume my comments were addressed
luishfonseca
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
FieldsTrait, which allows exposing the fields of an object. Will be super useful for serialization and editor UI.Checklist