Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove afterSystem and beforeSystem #505

Merged

Conversation

DiogoMendonc-a
Copy link
Contributor

Description

Removed all code related to ordering systems by systems, and renamed afterTag() and beforeTag() to after() and before(), respectively.

@DiogoMendonc-a DiogoMendonc-a linked an issue Sep 8, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-08 11:03 UTC

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (312227a) 24.53% compared to head (11e2a70) 24.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   24.53%   24.53%           
=======================================
  Files          86       86           
  Lines        7009     7009           
=======================================
  Hits         1720     1720           
  Misses       5289     5289           
Files Changed Coverage Δ
core/include/cubos/core/ecs/dispatcher.hpp 82.14% <ø> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA changed the title 399 remove aftersystem beforesystem from dispatcher cubos Remove afterSystem and beforeSystem Sep 8, 2023
@RiscadoA RiscadoA added A-Core A-Engine B-ECS C-Code-Quality A section of code that is hard to understand or change B-Cubos labels Sep 8, 2023
@RiscadoA RiscadoA merged commit 6aaf2a0 into main Sep 8, 2023
8 checks passed
@RiscadoA RiscadoA deleted the 399-remove-aftersystem-beforesystem-from-dispatcher-cubos branch September 8, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core A-Engine B-ECS C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove afterSystem, beforeSystem from Dispatcher & Cubos
2 participants