Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove afterSystem, beforeSystem from Dispatcher & Cubos #399

Closed
RiscadoA opened this issue May 29, 2023 · 0 comments · Fixed by #505
Closed

Remove afterSystem, beforeSystem from Dispatcher & Cubos #399

RiscadoA opened this issue May 29, 2023 · 0 comments · Fixed by #505
Assignees
Labels
A-Core A-Engine B-ECS C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes
Milestone

Comments

@RiscadoA
Copy link
Member

RiscadoA commented May 29, 2023

These methods, while at first seem okay to add, are prone to very weird template errors if lambdas are passed there.
We should remove them, and rename afterTag/beforeTag to after/before, which are actually used.

@RiscadoA RiscadoA removed the triage label Jun 5, 2023
@RiscadoA RiscadoA added this to the Core: ECS 1 milestone Jun 5, 2023
@RiscadoA RiscadoA modified the milestones: Core: ECS 1, Housekeeping, Jammable Engine, Nursery Aug 27, 2023
@RiscadoA RiscadoA changed the title Consider removing afterSystem, beforeSystem from Dispatcher & Cubos Remove afterSystem, beforeSystem from Dispatcher & Cubos Aug 28, 2023
@RiscadoA RiscadoA added A-Core A-Engine B-Dispatcher C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes B-ECS and removed core labels Aug 28, 2023
@DiogoMendonc-a DiogoMendonc-a linked a pull request Sep 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core A-Engine B-ECS C-Code-Quality A section of code that is hard to understand or change D-Trivial Can be done in 30 minutes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants