Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Nvidia ISAAC ROS 3.1 #286

Merged
merged 71 commits into from
Oct 17, 2024
Merged

Upgrade to Nvidia ISAAC ROS 3.1 #286

merged 71 commits into from
Oct 17, 2024

Conversation

jmblixt3
Copy link
Member

@jmblixt3 jmblixt3 commented Sep 29, 2024 •
edited by Isopod00
Loading

Upgrade to the latest Nvidia ISAAC ROS 3.1

jmblixt3 and others added 12 commits September 20, 2024 16:20
@jmblixt3
Initial attempt at isaac ros 3
c734698
@jmblixt3
More changes for initial build
128a29f
@BergerKing333
Changing /home/blixt to $HOME so the enter_container script runs on o…
4518971 
…ther computers
@BergerKing333
Swapped submodules to use isaac 3.1, deleted our docker.zed in favor …
8f491fb 
…of nvidias. Need to test still
@BergerKing333
The container works, building is broken with zed though
a2f7aa7
@BergerKing333
Merge branch 'main' into move-to-isaac-ros-3.1
745dd72
@Isopod00
Merge branch 'main' into move-to-isaac-ros-3.1
f1167b7
@BergerKing333
Minor changes to ros2_wrapper version, Isaac ros 3.1 builds now!!!!
f3539c1
@BergerKing333
Removing references to combine_esdf that were breaking nvblox.
ada0db5
@BergerKing333
Updating to ZED SDK 4.1. Uses our own Docker zed file to do so
57ddca9
@Isopod00
Merge branch 'main' into move-to-isaac-ros-3.1
ab19300
@Isopod00
Merge branch 'main' into move-to-isaac-ros-3.1
ce65b4a
@jmblixt3 jmblixt3 force-pushed the move-to-isaac-ros-3.1 branch 2 times, most recently from 537a48c to ce65b4a Compare September 29, 2024 23:31
@Isopod00 Isopod00 changed the title Move to isaac ros 3.1 Upgrade to Nvidia ISAAC ROS 3.1 Sep 30, 2024
@Isopod00 Isopod00 linked an issue Sep 30, 2024 that may be closed by this pull request
Upgrade our Nvidia Jetson AGX Orin to JetPack 6 and ISAAC ROS 3.1 #154
Closed
@Isopod00 Isopod00 added the enhancement New feature or request label Sep 30, 2024
@Isopod00 Isopod00 changed the title Upgrade to Nvidia ISAAC ROS 3.1 (WIP) Upgrade to Nvidia ISAAC ROS 3.1 Sep 30, 2024
@Isopod00 Isopod00 changed the title (WIP) Upgrade to Nvidia ISAAC ROS 3.1 Upgrade to Nvidia ISAAC ROS 3.1 Oct 1, 2024
Isopod00 and others added 19 commits October 4, 2024 17:01
@Isopod00
nvblox works with gazebo sim again!
299f98b
@Isopod00
Autoformatting
fe2c86c
Readding deesptream to gitignore
33b52d1
@jmblixt3
Update submodules
637cf6d
@jmblixt3
Add asset scripts
ae40418
@jmblixt3
Revert "Add asset scripts" and "Update submodules"
707b77f 
This reverts commit 637cf6d.
This reverts commit ae40418.
@jmblixt3
Add foxglove dependency
39e41d0
@Isopod00
Remove ros-humble-foxglove-msgs from the skipped keys
c3f4ffa
@Isopod00
Merge branch 'main' into move-to-isaac-ros-3.1
afaaab4
@umnrobotics
change to deepstream download, so it downloads arm64 on the jetson
1249777
@BergerKing333
Updating readme to include the new ngc installation stuff
3590f13
@umnrobotics
Changing this made it so deepstream didnt download with every build
cff9ebe
@Isopod00
ISAAC ROS 3.1 devcontainer fixes & improvements (#293)
4062d23
@Isopod00
Merge remote-tracking branch 'origin/main' into move-to-isaac-ros-3.1
5b989de
@Isopod00
Update README.md
0538838
@umnrobotics
Updating scripts to mount /rosbags in place of /ssd
7a09265
@umnrobotics
Removing old container entry info
72144a5
@Isopod00
Merge branch 'main' into move-to-isaac-ros-3.1
078af04
@BergerKing333
uploading can startup script that i got off jetson before wiping
8f5ea53
@jmblixt3 jmblixt3 removed their assignment Oct 14, 2024
jmblixt3
jmblixt3 commented Oct 14, 2024
View reviewed changes
Copy link
Member Author

@jmblixt3 jmblixt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some findings

.devcontainer/devcontainer.json Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
docker/scripts/install-zed-aarch64.sh Outdated Show resolved Hide resolved
docker/scripts/install-zed-x86_64.sh Outdated Show resolved Hide resolved
src/isaac_ros/isaac_ros_launch/package.xml Show resolved Hide resolved
src/rovr_control/package.xml Show resolved Hide resolved
@jmblixt3 jmblixt3 marked this pull request as ready for review October 14, 2024 22:19
@jmblixt3 jmblixt3 marked this pull request as draft October 15, 2024 01:45
@Isopod00 Isopod00 marked this pull request as ready for review October 16, 2024 21:00
@Isopod00 Isopod00 self-requested a review October 16, 2024 21:00
Isopod00
Isopod00 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Isopod00 Isopod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have tickets #289, #296, and #264 on the project board as reminders of what will need to be done next, this PR looks good to me.

@Isopod00 Isopod00 merged commit 77cbfb7 into main Oct 17, 2024
4 checks passed
@Isopod00 Isopod00 deleted the move-to-isaac-ros-3.1 branch October 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BergerKing333 BergerKing333 BergerKing333 left review comments

@Isopod00 Isopod00 Isopod00 approved these changes

Assignees

@BergerKing333 BergerKing333

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade our Nvidia Jetson AGX Orin to JetPack 6 and ISAAC ROS 3.1
4 participants
@jmblixt3 @Isopod00 @BergerKing333 @umnrobotics