Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/axis params enum like #83

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

Bey9434
Copy link
Contributor

@Bey9434 Bey9434 commented Jul 25, 2024

joy2twist.param.yamlのaxisパラメータをstringで与えられるように改善。
確認手順は以下のとおりです。

端末1
colcon build --packages-select joy2twist
source install/setup.bash
ros2 launch joy2twist joy2twist.launch.xml

端末2
ros2 run joy joy_node

端末3
ros2 topic echo /turtle1/cmd_vel

の端末3でDualsenseの入力を確認しました。

@Bey9434 Bey9434 requested a review from Autumn60 July 25, 2024 15:25
Copy link
Collaborator

@Autumn60 Autumn60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメント箇所について修正よろしくおねがいします。

@Autumn60 Autumn60 linked an issue Jul 26, 2024 that may be closed by this pull request
@Bey9434 Bey9434 requested a review from Autumn60 July 26, 2024 13:31
@Autumn60 Autumn60 enabled auto-merge (squash) July 26, 2024 13:52
Copy link
Collaborator

@Autumn60 Autumn60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Autumn60 Autumn60 merged commit 10da925 into main Jul 26, 2024
3 checks passed
@Autumn60 Autumn60 deleted the improvement/axis-params-enum-like branch July 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

joy2twist.param.yamlパラメータのEnum-like化
2 participants