Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because I got the error below when I try to release new version of next-metrics
https://circleci.com/gh/Financial-Times/next-metrics/2238
npx
is provided fromnpm version ^5.2.0
The Circle build's npm version is
3.10.10
mitm
version to the latest(1.7.0)The
npx
issue is resolved by node version update but I get a different error related to the update.https://circleci.com/gh/Financial-Times/next-metrics/2240
mitm
needs to be update from1.2.0
to^1.3.2
to solve the error.When I updated
mitm
version, I got a different error with the same test.https://circleci.com/gh/Financial-Times/next-metrics/2246
Somehow
clock
in the test causes the error. The test needs to checkLogging to graphite
. It is not super important to know what exactly is the log at this point. Theclock
is deleted to solve the issue to able to release new version of next-metrics.However, the time stamp thing is nice to have so I created #339 for someone has time to tackle to put sinon clock back.