Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back clock for 'Send metrics to Graphite' test to check logging detail #339

Open
fenglish opened this issue Sep 6, 2019 · 0 comments

Comments

@fenglish
Copy link
Contributor

fenglish commented Sep 6, 2019

This commit 54bf44c removed sinon clock from Send metrics to Graphite test because an error is thrown when mitm version was updated .

  1 failing

  1) Logging to graphite
       Send metrics to Graphite:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/circleci/project/build/test/unit/client.spec.old.js)

https://circleci.com/gh/Financial-Times/next-metrics/2246

Somehow clock in the test causes the error. The test needs to check Logging to graphite. It is not super important to know what exactly is the log at this point. The clock is deleted to solve the error to able to release new version of next-metrics.

However, the time stamp by sinon clock in the log in the test is nice to have.
It may be resolved by updating sinon version.

All detail is in this PR => #337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant