Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#806: Move data.db to s3 and download via download_large_files #807

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

levineds
Copy link
Collaborator

@levineds levineds commented Aug 13, 2024

To resolve transient download error, we will download from s3 via download_large_files. It's not clear if this will 100% resolve the download issue, but we will be able to catch errors and resolve if they arise.

@levineds levineds linked an issue Aug 13, 2024 that may be closed by this pull request
@levineds levineds added bug Something isn't working documentation Improvements or additions to documentation patch Patch version release labels Aug 13, 2024
Copy link
Collaborator

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/fairchem/core/scripts/download_large_files.py 73.07% <ø> (+7.69%) ⬆️

@zulissimeta zulissimeta added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit cb05238 Aug 13, 2024
8 of 11 checks passed
@zulissimeta zulissimeta deleted the data_db_to_s3 branch August 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation patch Patch version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transient download problem for docs
2 participants