Use useLayoutEffect instead of useEffect for string parsing and height measurements
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
CLA throws a 404 |
Merged
|
Oops - CLA should is added now! |
tomekzaw
requested changes
Feb 19, 2024
src/MarkdownTextInput.web.tsx
Outdated
| @@ -464,7 +466,7 @@ const MarkdownTextInput = React.forwardRef<TextInput, MarkdownTextInputProps>( | |||
| updateTextColor(divRef.current, value); | |||
| }, [multiline, processedMarkdownStyle, processedValue]); | |||
|
|
|||
| useEffect(() => { | |||
| useClientEffect(function adjustHeightt() { | |||
There was a problem hiding this comment.
Suggested change
| useClientEffect(function adjustHeightt() { | |
| useClientEffect(function adjustHeight() { |
src/MarkdownTextInput.web.tsx
Outdated
| @@ -9,7 +9,7 @@ import type { | |||
| TextInputKeyPressEventData, | |||
| TextInputFocusEventData, | |||
| } from 'react-native'; | |||
| import React, {useEffect, useRef, useCallback, useMemo} from 'react'; | |||
| import React, {useEffect, useRef, useCallback, useMemo,useLayoutEffect} from 'react'; | |||
There was a problem hiding this comment.
Suggested change
| import React, {useEffect, useRef, useCallback, useMemo,useLayoutEffect} from 'react'; | |
| import React, {useEffect, useRef, useCallback, useMemo, useLayoutEffect} from 'react'; |
robertKozik
changed the title
useLayoutEffect insted of useEffect for string parsing and height measurements
tomekzaw
approved these changes
Feb 19, 2024
|
@nandorojo can You sign the CLA so we would be able to proceed with the merge 🙇🏼 |
|
I have read the CLA Document and I hereby sign the CLA |
tomekzaw
changed the title
useLayoutEffect insted of useEffect for string parsing and height measurementsuseLayoutEffect instead of useEffect for string parsing and height measurements
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
It's ideal for cases where dimensions are derived from a DOM element and then updates some other element before react paints the screen. These seem like good use cases.
Related Issues
GH_LINK
close #166
Manual Tests
I didn't add any tests, I'll try a video comparison maybe?
Linked PRs