-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move height to layout effect #166
Comments
The same would go for this effect: react-native-live-markdown/src/MarkdownTextInput.web.tsx Lines 452 to 465 in 348fcd2
I can test them out a bit to be certain |
@nandorojo Thanks for reviewing the code and suggesting the improvements, feel free to submit PRs! cc @Skalakid, the author of web implementation |
Cool. Making a small note for SSR support: const useClientEffect = typeof window === 'undefined' ? useEffect : useLayoutEffect |
FYI There's a PR that eliminates |
Sounds good. Also, PR opened #169 |
react-native-live-markdown/src/MarkdownTextInput.web.tsx
Lines 467 to 474 in 348fcd2
Hey! Reviewing the web code, and I'm wondering if this should get moved to a layout effect since it's adjusting the height and you'd want to do this before painting. I'm happy to PR it if so!
The text was updated successfully, but these errors were encountered: