Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add s3 fixtures for retrying logic #1206

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Aug 1, 2023

Adds FastAPI fixtures for testing s3 error handling and retry logic

The current server serves two buckets:

  1. s3://head-retries-bucket/{status_code}/{num_errors}/{item_id}: for a given item_id, will throw the status code num_errors times on HEAD requests before giving a successful response
  2. s3://get-retries-bucket/{status_code}/{num_errors}/{item_id}: for a given item_id and byte-range, will throw the status code num_errors times on ranged GET requests before giving a successful response

@github-actions github-actions bot added the chore label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1206 (566a058) into main (bc11e57) will increase coverage by 0.01%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   88.40%   88.41%   +0.01%     
==========================================
  Files          55       55              
  Lines        5606     5620      +14     
==========================================
+ Hits         4956     4969      +13     
- Misses        650      651       +1     

see 2 files with indirect coverage changes

@jaychia jaychia merged commit e95acae into main Aug 1, 2023
18 checks passed
@jaychia jaychia deleted the jay/s3-retry-testing branch August 1, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant