Skip to content

Commit

Permalink
Re-enable non-anonymous mode which does retries, but add github actio…
Browse files Browse the repository at this point in the history
…n to assume credentials
  • Loading branch information
Jay Chia committed Aug 1, 2023
1 parent 2499eaa commit 8158ec0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,12 @@ jobs:
run: |
mkdir -p /tmp/daft-integration-testing/nginx
chmod +rw /tmp/daft-integration-testing/nginx
- name: Assume GitHub Actions AWS Credentials
uses: aws-actions/configure-aws-credentials@v2
with:
aws-region: us-west-2
role-to-assume: ${{ secrets.ACTIONS_AWS_ROLE_ARN }}
role-session-name: DaftPythonPackageGitHubWorkflow
- name: Spin up IO services
uses: isbang/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/io/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def nginx_config() -> tuple[str, pathlib.Path]:
def retry_server_s3_config() -> daft.io.IOConfig:
"""Returns the URL to the local retry_server fixture"""
return daft.io.IOConfig(
s3=daft.io.S3Config(endpoint_url="http://127.0.0.1:8001", anonymous=True),
s3=daft.io.S3Config(endpoint_url="http://127.0.0.1:8001"),
)


Expand Down

0 comments on commit 8158ec0

Please sign in to comment.