Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable feature-flagged native downloader in daft.read_parquet #1190

Merged
merged 13 commits into from
Jul 31, 2023

Test native downloader for Parquet reads in test_creation.py

429b05c
Select commit
Loading
Failed to load commit list.
Merged

[FEAT] Enable feature-flagged native downloader in daft.read_parquet #1190

Test native downloader for Parquet reads in test_creation.py
429b05c
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jul 27, 2023 in 0s

88.38% (+0.00%) compared to 440b8b3

View this Pull Request on Codecov

88.38% (+0.00%) compared to 440b8b3

Details

Codecov Report

Merging #1190 (429b05c) into main (440b8b3) will increase coverage by 0.00%.
The diff coverage is 78.57%.

❗ Current head 429b05c differs from pull request most recent head 37b0976. Consider uploading reports for the commit 37b0976 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1190   +/-   ##
=======================================
  Coverage   88.37%   88.38%           
=======================================
  Files          54       54           
  Lines        5576     5598   +22     
=======================================
+ Hits         4928     4948   +20     
- Misses        648      650    +2     
Files Changed Coverage Δ
daft/runners/runner_io.py 91.66% <ø> (ø)
daft/table/table_io.py 92.00% <50.00%> (-2.74%) ⬇️
daft/io/parquet.py 93.33% <66.66%> (-6.67%) ⬇️
daft/table/schema_inference.py 94.59% <75.00%> (-2.38%) ⬇️
daft/datasources.py 93.93% <80.00%> (-2.49%) ⬇️
daft/filesystem.py 86.07% <100.00%> (+0.45%) ⬆️
daft/table/table.py 88.79% <100.00%> (+1.29%) ⬆️

... and 1 file with indirect coverage changes