[FEAT] Enable feature-flagged native downloader in daft.read_parquet #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
+ Coverage 88.37% 88.40% +0.02%
==========================================
Files 54 55 +1
Lines 5576 5606 +30
==========================================
+ Hits 4928 4956 +28
- Misses 648 650 +2
|
added 5 commits
July 26, 2023 20:06
…file metadata retrieval
jaychia
force-pushed
the
jay/parquet-pyarrow-switch-to-table
branch
from
e118673
to
1e5309e
Compare
jaychia
changed the title
jaychia
commented
Jul 27, 2023
| parquet_statistics = Table.read_parquet_statistics( | ||
| list(filepaths_to_infos.keys()), source_info.io_config | ||
| ).to_pydict() | ||
| for path, num_rows in zip(parquet_statistics["uris"], parquet_statistics["row_count"]): |
There was a problem hiding this comment.
NOTE: This code relies on hardcoded strings which are the names of the table's series. A little error prone perhaps?
| @@ -364,6 +364,6 @@ def read_parquet_statistics( | |||
| io_config: IOConfig | None = None, | |||
| ) -> Table: | |||
| if not isinstance(paths, Series): | |||
| paths = Series.from_pylist(paths) | |||
|
|
|||
| paths = Series.from_pylist(paths, name="uris") | |||
There was a problem hiding this comment.
NOTE: Our Series objects default to the name "list_col". Modified here to have a better name, but needs to be consistent across calls and so I added an assert after.
src/daft-io/src/python.rs
Outdated
| @@ -34,6 +34,20 @@ impl PyIOConfig { | |||
| config: self.config.s3.clone(), | |||
| }) | |||
| } | |||
|
|
|||
| pub fn __setstate__(&mut self, py: Python, state: PyObject) -> PyResult<()> { | |||
There was a problem hiding this comment.
Had to make this class pickleable for our optimizer's deepcopy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables changes to
daft.read_parquetsuch that when we specifyuse_native_downloader=True, this uses our new Rust-based native Parquet downloading and parsing for:Table