Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Transaction Collection and block Creation to Separate Task #1749

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Split Transaction Collection and block Creation to Separate Task #1749

merged 9 commits into from
Sep 15, 2023

Conversation

bfish713
Copy link
Collaborator

All transaction handling should be moved to one place and out of the main consensus/da tasks

@bfish713 bfish713 linked an issue Sep 14, 2023 that may be closed by this pull request
Create Builder Task for Handling Transaction #1501
Closed
@bfish713 bfish713 marked this pull request as ready for review September 14, 2023 15:40
@bfish713 bfish713 mentioned this pull request Sep 14, 2023
Merged
shenkeyao
shenkeyao requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the event filter needs to be updated. Other comments are nit issues.

crates/hotshot/src/tasks/mod.rs Outdated Show resolved Hide resolved
crates/testing/tests/network_task.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
crates/task-impls/src/transactions.rs Outdated Show resolved Hide resolved
shenkeyao
shenkeyao previously approved these changes Sep 15, 2023
View reviewed changes
@bfish713 bfish713 merged commit 2e418d7 into main Sep 15, 2023
6 checks passed
@bfish713 bfish713 deleted the bf/block-task branch September 15, 2023 18:24
@bfish713 bfish713 mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-maron rob-maron rob-maron approved these changes

@shenkeyao shenkeyao shenkeyao left review comments

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Builder Task for Handling Transaction
3 participants
@bfish713 @shenkeyao @rob-maron