Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Builder Task for Handling Transaction #1501

Closed
bfish713 opened this issue Aug 4, 2023 · 0 comments · Fixed by #1749
Closed

Create Builder Task for Handling Transaction #1501

bfish713 opened this issue Aug 4, 2023 · 0 comments · Fixed by #1749
Assignees
Labels
Milestone

Comments

@bfish713
Copy link
Collaborator

bfish713 commented Aug 4, 2023

The builder task should consolidate the transaction handling logic in one place and emit BlockSubmitted events to the DA task at appropriate times.

Proposed logic:

  • On TransactionRecv: Add the transaction to our memory pool of transaction, or remove it from seen transactions cache
  • on DecideEvent: Remove any transactions comitted from transactions and add unseen transaction which were committed to our seen transactions cache.
  • on ViewChange: If we are leader for view + 3 start transaction polling. If leader view + 1 try to form a block (i.e do wait_for_transactons) and emit the list of transactions as a block in a BlockSubmitted event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants